Fix #2238: Add proper parsing for resource uses pattern#2334
Open
kellyelton wants to merge 1 commit into
Open
Conversation
- Add parse_resource_uses() function to handle 'uses (X)' patterns - Return 0 when no digits found instead of crashing - This fixes the NullReferenceException when using Akachi's Spirit-Speaker card in Arkham Horror package Co-authored-by: Kelly Elton <its.the.doc@gmail.com>
kellyelton
added
octgn-issue-bot
Member
Author
|
🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements). |
Member
Author
|
🤖🧐 ✅ Automated Code Review — PASSED PR: #2334 — Fix #2238: Add proper parsing for resource uses pattern Level 1: Standard Code Review ✅ Level 2: Security Review ✅ Level 3: Requirements Review ✅ All 3 review levels passed. Ready for merge. |
kellyelton
removed
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2238
Problem: When using Akachi's Spirit-Speaker card in the Arkham Horror package, the game would crash with a NullReferenceException when trying to parse resource uses text.
Root Cause: The code was trying to parse text like 'uses (X)' to extract the number of resource tokens, but it didn't handle the case when no digits were found in the pattern, causing a crash.
Solution: Added a function that properly handles the 'uses (...)' pattern and returns 0 when no digits are found, preventing the crash.
Files Changed:
Testing: This fix addresses the specific issue mentioned in the bug report where using Akachi's Spirit-Speaker card would cause the game to crash.